Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to add token name with 11+ characters in Metamask #1466

Closed
0xtzData opened this issue Jan 1, 2024 · 5 comments
Closed

Failed to add token name with 11+ characters in Metamask #1466

0xtzData opened this issue Jan 1, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@0xtzData
Copy link

0xtzData commented Jan 1, 2024

Frontend: v1.21.0-alpha.1

  1. Connect your Metamask wallet to the site
  2. Go to https://eth-goerli.blockscout.com/tokens
  3. Try to add VanityTRX.org token

Expected behavior: We should be able to import any token by Symbol
Actual behavior: We can't add token with 11+ characters in name/symbol

Image

@0xtzData 0xtzData added the bug Something isn't working label Jan 1, 2024
@tom2drum tom2drum self-assigned this Jan 8, 2024
@tom2drum
Copy link
Collaborator

The MM docs says that maximum token symbol length is 11. But if I strip token symbol down to 11 characters, I get this error:

Image

It appears to be impossible to add a token to MM with a symbol longer than 11 characters right now.

@NikitaSavik
Copy link
Contributor

  • create issue for MM
  • hide 'add to Metamask' button for tokens with longer than 11 chars in its symbol

@tom2drum
Copy link
Collaborator

Here is an issue in the MM wallet repository that requests an increase in the allowed token symbol length: MetaMask/metamask-extension#9243. A pull request addressing this issue is currently in progress. It might be best to wait until it is resolved.

@repository23
Copy link

Terrible, why so
why metamask check token name fully not just the begining or best nothing ... if some flag is set to do not check names

@NikitaSavik
Copy link
Contributor

The bug is on the Metamask side. We will continue to monitor situation, but closing the issue, since no action needed

@NikitaSavik NikitaSavik closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants