Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App letterboxing on modern phones #27

Open
matthewspear opened this issue Jan 28, 2019 · 5 comments
Open

App letterboxing on modern phones #27

matthewspear opened this issue Jan 28, 2019 · 5 comments

Comments

@matthewspear
Copy link

I think once a few of the current regressions are fixed (#25, #26) it would be worth another release to the App Store, current one is 2 years old.

Recently in the past year newer phones with an updated screen resolution have come out ( X, XR, XS, XS Max). To avoid breaking changes, apps built before this change run in a letterbox:

img_8259

I've tested it out and all that needs to be done is rebuild the app targeting iOS 12 to support the new screen resolutions.

Happy to help push to the store given the correct details or setup a CD system to build from Master!

@ataffanel
Copy link
Member

I agree with making a new version. When I test the current version in the new iPhone emulator there is no lettering so I guess just compiling with the new xcode will solve that?

I have everything setup for releasing to the store so that should not be a problem. Though getting a working travis configuration for the project would be nice to make sure commits builds.

@matthewspear
Copy link
Author

matthewspear commented Jan 29, 2019

Yeah just a rebuild will do it. I have access to an iPhone X so can verify it works on hardware.

In the past I’ve used a combination of Bitrise and Fastlane. Allowing for every push to a develop branch triggering testflight builds and to master a full store release.

In terms of the regressions, if I can solve them I hope to start building up some unit tests too.

@matthewspear
Copy link
Author

Bitrise also offer accounts for open source projects too - here

@ataffanel
Copy link
Member

This all sounds good and the idea could also be applied to the Android app which is nice :).

We usually use master as development branch and tag releases, but I guess these tools can be applied to this workflow as well.

@matthewspear
Copy link
Author

matthewspear commented Jan 29, 2019

All these actions can be triggered manually, but suits a git-flow approach and feature branches.

Yeah familiar with a bit of Android development but I’m sure setup is similar and Fastlane also supports Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants