Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing actions in execute list #37

Closed
soulfire03 opened this issue Jan 30, 2021 · 12 comments
Closed

Missing actions in execute list #37

soulfire03 opened this issue Jan 30, 2021 · 12 comments
Labels
class Concerns one class only (things, sun, variables, ...) editor Concerns the editor view enhancement New feature or request

Comments

@soulfire03
Copy link

Using the macro addon, I wanted to display a toast notification on my LG TV.

With the "set attribute to value" object, the only items listed are On, Off, Mute and Active App.
And with the "execute thing action" object, I have 7x "undefined" items listed.

Would it be possible to address that please?

@bewee
Copy link
Owner

bewee commented Jan 30, 2021

Hi @soulfire03,

I need some more information to have a look at this. First of all: Could you please tell me which adapter add-on you use to connect your LG TV to the gateway? And also: Can you use the action which you want to use in your macro in a rule? Maybe your TV's adapter changes visibility of its actions in the things view? (I can try to have a look at your TV's adapter's source if you tell me about that).
Also, it may be helpful if you could send some screenshots or log snippets.

Regards :)

@bewee bewee added the bug Something isn't working label Jan 31, 2021
@soulfire03
Copy link
Author

Hello!

I'm using the LV webOS TV adapter :
adapter

Using the adapter in the rules page, I'm able to send a toast notification on the TV, so it's working fine :
rule

Notice that there are 3 parameters for this "toast" TV action. I don't know how this can be implemented in a macro's execute action.

Here is the macro window. Even if it's working in a rule, I wanted to do this in a macro because I would use a variable :
macro

Let me know if you need something else! :)
BTW, this macro addon is a very impressive piece of work. Good job!
Thanks

@bewee
Copy link
Owner

bewee commented Jan 31, 2021

Hi @soulfire03,

the LG TV adapter realizes the toast functionality using a notifier, not using thing's actions (although I have no clue where these undefineds are from). Unfortunately, the macro add-on currently has no support for notifications. However, I opened a new issue #38 and hope we can get this implemented!

Regards :)

@bewee
Copy link
Owner

bewee commented Feb 4, 2021

Hi @soulfire03,

I got a first version running. There are still some things to be done, but could you please already have a look at it by cloning the branch inputActions and give me some feedback?

Regards :)

@soulfire03
Copy link
Author

I'm not sure on how to put the code and compile it on the Pi.

@bewee
Copy link
Owner

bewee commented Feb 5, 2021

Hi @soulfire03,

do you have remote access (ssh) enabled on your pi (have a look at settings >> developer), and do you know hot to connect to it this way?

Regards :)

@bewee
Copy link
Owner

bewee commented Feb 7, 2021

Hi @soulfire03,

because I made quite a few structural changes during implementation of parameterized actions, I just released an update for the macrozilla add-on. I hope this fixes your issue (I tested everything with virtual things, and it worked well with these).
image
If so, you can close this issue. If not, please report back :)

Regards

@bewee bewee added back end Concerns code running on the server editor Concerns the editor view enhancement New feature or request front end Concerns code running in the client's web browser class Concerns one class only (things, sun, variables, ...) and removed bug Something isn't working back end Concerns code running on the server front end Concerns code running in the client's web browser labels Feb 7, 2021
@soulfire03
Copy link
Author

Yes sorry, I've been busy this weekend.
I tried the update but I am not able to create or open an existing macro. The macro window shows but there is no objects in the left panel.
macro

@bewee
Copy link
Owner

bewee commented Feb 8, 2021

Hi @soulfire03,

this should not happen! I installed the upate on my personal gateway too and experienced no such behaviour there. Could you please have a look at the developer console of your browser (tutorial: https://balsamiq.com/support/faqs/browserconsole/) and send me the logs from there?

You may also try creating a new macro and tell me whether this works?

Regards

@soulfire03
Copy link
Author

Oh, it was some javascript files missing. I did a hard refresh to clear the cache and it was solved.

@soulfire03
Copy link
Author

I was able to build the macro and add the Toast action for the TV. However when I execute it or if I wait for the trigger to fire, nothing happens. I suspect that I did not build it correctly, so I will close this issue and read more carefully on how to properly create macros.
Thank you for your help

@bewee
Copy link
Owner

bewee commented Feb 8, 2021

Alright. Feel free to re-open the issue in case you are stuck. You can also send a screenshot of your macro and I will have a look at it :)

Edit:
Concerning the screenshot from above, I would suggest you to try to remove the conditions and then try again. Conditions always have to be fullfilled in order for execution to start.
Oh, and you may also try to press the play button in the bottom right corner. This one should execute your macro without any check of triggers and conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class Concerns one class only (things, sun, variables, ...) editor Concerns the editor view enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants