From e6d877833349b802b225ed35011731e1fee14545 Mon Sep 17 00:00:00 2001 From: "Image Builder Bot[tm]" Date: Fri, 1 Nov 2024 03:01:11 +0000 Subject: [PATCH 1/3] update a11y image tag to 9734acc88b90 --- deployments/a11y/hubploy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployments/a11y/hubploy.yaml b/deployments/a11y/hubploy.yaml index bfe84d961..16533ee60 100644 --- a/deployments/a11y/hubploy.yaml +++ b/deployments/a11y/hubploy.yaml @@ -1,6 +1,6 @@ images: images: - - name: us-central1-docker.pkg.dev/ucb-datahub-2018/user-images/a11y-user-image:710a5e6cc90c + - name: us-central1-docker.pkg.dev/ucb-datahub-2018/user-images/a11y-user-image:9734acc88b90 cluster: provider: gcloud From 5296643ad9d28752de51724bf4af7c676dd72ffc Mon Sep 17 00:00:00 2001 From: sean-morris Date: Sun, 3 Nov 2024 15:08:39 -0800 Subject: [PATCH 2/3] Updated README - pre-commit config --- README.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/README.md b/README.md index e56cd0814..24639cc1d 100644 --- a/README.md +++ b/README.md @@ -29,6 +29,15 @@ editing, testing, building and deploying hubs. The other python package definition file, `requirements.txt` is used solely by our Github Actions CI/CD pipeline. +## Pre-Commit hooks: Installing + +The previous step, `pip install -r dev-requirements.txt`, installs the package, pre-commit. +This is used to run a series of commands defined in the file, .pre-commit-config.yaml, to help ensure no mistakes are committed to the repo. + +After the pip install command execute the following: +-- `pre-commit install` +-- `pre-commit run --all-files` + ## Setting up your fork and clones First, go to your [github profile settings](https://github.com/settings/keys) From 5c093a62ba5a0fdf1633e4c1bbb60c2ba3205f49 Mon Sep 17 00:00:00 2001 From: shane knapp Date: Mon, 4 Nov 2024 10:11:39 -0800 Subject: [PATCH 3/3] small readability updates to the readme --- README.md | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 24639cc1d..92b9a7f8a 100644 --- a/README.md +++ b/README.md @@ -31,12 +31,18 @@ our Github Actions CI/CD pipeline. ## Pre-Commit hooks: Installing -The previous step, `pip install -r dev-requirements.txt`, installs the package, pre-commit. -This is used to run a series of commands defined in the file, .pre-commit-config.yaml, to help ensure no mistakes are committed to the repo. +The previous step, `pip install -r dev-requirements.txt`, installs the package +[`pre-commit`](https://pre-commit.com/). This is used to run a series of +commands defined in the file [`.pre-commit-config.yaml`](https://github.com/berkeley-dsep-infra/datahub/blob/staging/.pre-commit-config.yaml) +to help ensure no mistakes are committed to the repo. -After the pip install command execute the following: --- `pre-commit install` --- `pre-commit run --all-files` +After you've installed `dev-requirements.txt`, execute the following two +commands: + +``` +pre-commit install +pre-commit run --all-files +``` ## Setting up your fork and clones