Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403 recieved when creating mutex should not be retried #15

Open
leemeador opened this issue Nov 6, 2023 · 1 comment
Open

403 recieved when creating mutex should not be retried #15

leemeador opened this issue Nov 6, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@leemeador
Copy link

Currently:

When the token supplied does not have permission to create the mutex thingy in the repo, the call to the github api returns HTTP 403 (forbidden). Then the action waits a bit and reties and it still does not have permission. This will repeat for, literally, hours until someone notices and cancels.

Suggested:

When the action code recieves a 403, that would fail the action. (Perhaps 401 (unauthorized) too but I haven't seen a 401.)

Related note:

We are seeing this when the mutex is trying to be set from a fork. Our settings do not allow forks to access our secrets. I suspect a similar thing would happen if the default token was used since it would not have write permission in a fork.

The same thing could happen if a token expired.

@ben-z
Copy link
Owner

ben-z commented Dec 12, 2023

Thanks for the suggestion! For the record, #4 seems related and could alleviate this situation too.

@ben-z ben-z added the help wanted Extra attention is needed label Dec 12, 2023
This was referenced Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants