Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more themes #9

Open
hhaio opened this issue Feb 3, 2022 · 4 comments
Open

Add more themes #9

hhaio opened this issue Feb 3, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@hhaio
Copy link

hhaio commented Feb 3, 2022

As the title suggests, the default dark theme is nice but it is kinda hard to distinguish the number pad from rest of the ui color

1.May be change the numbers color to different shades of dark than the rest ui color
2. Would be cool if you added other dark themes

@tepozoa
Copy link

tepozoa commented Feb 4, 2022

I have been using Calctastic (not open source), read issue #6 and wanted to offer their UI design as something to look at (not embedding image here in case it breaks a copyright):

I also find the button contrast too hard to work with in Dark mode; not that we want to copy the above design but more of inspiration of what can be done to help use darker/lighter shades of grey to increase the visual distinction of the buttons in Dark mode.

@danger-ahead
Copy link
Collaborator

Thanks for the feedback. Will look into it.

@bartick
Copy link
Contributor

bartick commented Feb 5, 2022

I can try fixing the button styles for using the button easily in a dark theme.

@danger-ahead danger-ahead added the enhancement New feature or request label Feb 6, 2022
@hhaio
Copy link
Author

hhaio commented Feb 10, 2022

I have been using Calctastic (not open source), read issue #6 and wanted to offer their UI design as something to look at (not embedding image here in case it breaks a copyright):

I also find the button contrast too hard to work with in Dark mode; not that we want to copy the above design but more of inspiration of what can be done to help use darker/lighter shades of grey to increase the visual distinction of the buttons in Dark mode.

That design is perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants