Ignore .DS_Store files in the validation of single xcassets type #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.DS_Store` doesn't represent an xcassets type -- those files don't prevent the asset catalog compile action to execute. They can be generated and accidentally included if the user open the `.xcassets` directory in the Finder. This ignores all the `.DS_Store` files in the validation logic, to avoid failing the build unnecessarily.
thii
force-pushed
the
fix-ensure_single_xcassets_type-validation
branch
from
97a705b to
bc2cf65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.DS_Storedoesn't represent an xcassets type -- those files don'tprevent the asset catalog compile action to execute. They can be
generated and accidentally included if the user open the
.xcassetsdirectory in the Finder. This ignores all the
.DS_Storefiles in thevalidation logic, to avoid failing the build unnecessarily.
Fixes #302.