You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pre-git breaks the .git hooks because it always require to look for ./node_modules in the root app. However our application as been restructured to enforce MAVEN strict folder structure. Hence we now put all our root files under src/main/webapp/. This causes the pre-git to no longer find installed pre hooks easily because it expects them to be under ./node_modules/.bin/pre-commit for example. Can you please take a look.
The text was updated successfully, but these errors were encountered:
Not sure how to do this then - should it read the node_modules path from the package.json maybe? If that's there. I would be open to you making the code changes and sending me a pull request.
I think it should read the node_modules from the path that 'npm install' put the installed libraries instead of always seeking to find the node_modules folder in the root(./). Our package.json now leaves in /src/main/webapp so also is the node_modules folder. This was based on the forced folder structure needed by Maven. Every other node module plugin installed works fine but just the pre-git hence we've lost the benefit of having our code quality check before pushing to remote git.
Pre-git breaks the .git hooks because it always require to look for ./node_modules in the root app. However our application as been restructured to enforce MAVEN strict folder structure. Hence we now put all our root files under src/main/webapp/. This causes the pre-git to no longer find installed pre hooks easily because it expects them to be under ./node_modules/.bin/pre-commit for example. Can you please take a look.
The text was updated successfully, but these errors were encountered: