Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unbonding delegation when creating withdraw tx #22

Closed
jrwbabylonlab opened this issue Sep 11, 2024 · 1 comment
Closed

Check unbonding delegation when creating withdraw tx #22

jrwbabylonlab opened this issue Sep 11, 2024 · 1 comment
Assignees

Comments

@jrwbabylonlab
Copy link
Collaborator

jrwbabylonlab commented Sep 11, 2024

When we create the withdraw early unbonded transaction, we require unbonding tx as the input. However, we never check the legibility of the transaction to make sure it's indeed is the unbonding tx and pointing to the right staking tx that we want to withdraw from.

The scope of this issue is to add such check in the btc-staking-ts lib and make sure have sufficient test coverages

@jrwbabylonlab
Copy link
Collaborator Author

After looking deep into the code, it does not seem we need such check as the btc will reject if the input does not match from previous tx output anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant