Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ValidateBasic() for tx messages #369

Open
lukema95 opened this issue Dec 23, 2024 · 1 comment
Open

feat: Add ValidateBasic() for tx messages #369

lukema95 opened this issue Dec 23, 2024 · 1 comment

Comments

@lukema95
Copy link

Summary

Several module message types are missing ValidateBasic() validation. This method is crucial for performing basic stateless checks before messages reach the handler, helping to catch invalid messages early.

Problem Definition

  • Improved message validation
  • Catch invalid messages early
  • Consistent with Cosmos SDK best practices
  • Enhanced code maintainability

Proposal

Add ValidateBasic() implementation for each message type to validate:

  • Required fields are not empty/zero
  • Field formats are correct (e.g., valid addresses, heights, etc.)
  • Basic logical constraints are met
@lukema95
Copy link
Author

Please let me know if you'd like me to create a PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant