Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode list styles on privacy policy.html by adding color adju… #3307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akshay0611
Copy link
Contributor

🛠️ Fixes Issue

Fixes: #3306

👨‍💻 Description

What does this PR do?

This PR resolves an issue where the text inside <ul> and <ol> elements in the privacy policy.html page becomes unreadable when dark mode is enabled.

  • Adjusted the styles for <ul>, <ol>, and <li> elements to ensure proper text visibility in dark mode.
  • Ensured the text color changes to a lighter color when dark mode is enabled for better contrast against the dark background.
  • These changes enhance the accessibility and readability of the page in dark mode.

📄 Type of Change

  • [✅] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

📷 Screenshots/GIFs (if any)

Before Fix:

Screenshot 2024-11-19 at 2 49 11 PM

After Fix:

Screenshot 2024-11-19 at 2 50 30 PM

✅ Checklist

  • [] I am a participant of GSSoC-ext.
  • [✅] I have followed the contribution guidelines of this project.
  • [✅] I have made this change from my own.
  • I have taken help from some online resources.
  • [✅] My code follows the style guidelines of this project.
  • [✅] I have performed a self-review of my own code.
  • [] I have added documentation to explain my changes.

Mandatory Tasks

  • [✅] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🤝 GSSoC Participation

  • [] This PR is submitted under the GSSoC program.
  • [] I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
finveda ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:38am

Copy link

Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for getfinveda ready!

Name Link
🔨 Latest commit f88d74f
🔍 Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/673c5ae75bcffa0008fba65d
😎 Deploy Preview https://deploy-preview-3307--getfinveda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 39
Accessibility: 63
Best Practices: 75
SEO: 73
PWA: 50
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Dark Mode List Items Unreadable in privacy policy.html
1 participant