Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct Links for Terms of Service and Privacy Policy in Newsletter Popup on index.html #3292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akshay0611
Copy link
Contributor

πŸ› οΈ Fixes Issue

Fixes: #3291

πŸ‘¨β€πŸ’» Description

What does this PR do?

This pull request fixes the issue with the Terms of Service and Privacy Policy links inside the newsletter popup on the index.html page.

  • The initial problem was that the links in the popup were not working correctly. The URLs were incorrectly formed and did not navigate to the appropriate pages.
  • The links have now been updated to the correct paths, ensuring they navigate to the Terms of Service and Privacy Policy pages as expected.
  • This change enhances the user experience by making the popup fully functional and the links accessible.

πŸ“„ Type of Change

  • [βœ… ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

N/A

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • [βœ… ] I have followed the contribution guidelines of this project.
  • [βœ… ] I have made this change from my own.
  • I have taken help from some online resources.
  • [βœ… ] My code follows the style guidelines of this project.
  • [βœ… ] I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • [βœ… ] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
finveda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 17, 2024 6:57am

Copy link

netlify bot commented Nov 17, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit 858bfeb
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/673993c4158b02000825f6d0
😎 Deploy Preview https://deploy-preview-3292--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 37
Accessibility: 63
Best Practices: 75
SEO: 73
PWA: 50
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Links in Newsletter Popup on index.html
1 participant