Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fires twice if props/state changes causes re-mapping of the fired key #151

Open
gforge opened this issue Sep 17, 2018 · 0 comments
Open

Comments

@gforge
Copy link
Contributor

gforge commented Sep 17, 2018

I've found that if the parent components props/state changes when an event is fired it will re-trigger the same event, i.e. firing twice. To be more specific, it happened when a new react-key-handler component with the same key binding was created on a different element. To illustrate the components

[button one, key 1], [button two, key 2], [button three, key 3]

when I pressed 2 the button one would disappear and the keys would with new bindings:

[button two, key 1], [button three, key 2]

I've solved this by adding a setTimeout(.., 0) to the call. This could possibly be activated through a prop that wraps the onKeyHandle in a setTimeout function.

@gforge gforge changed the title Fires twice if props/state changes du to update Fires twice if props/state changes causes re-mapping of the fired key Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant