Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print snapshot-id when coldsnap is terminated before finishing upload #332

Open
arianvp opened this issue Apr 20, 2024 · 1 comment · May be fixed by #336
Open

Print snapshot-id when coldsnap is terminated before finishing upload #332

arianvp opened this issue Apr 20, 2024 · 1 comment · May be fixed by #336
Assignees

Comments

@arianvp
Copy link

arianvp commented Apr 20, 2024

When coldsnap is terminated it leaves a pending / error snapshot around. It'd be nice of coldsnap would print out the snapshot-id if it exits uncleanly so it can be removed by the user

@arianvp arianvp changed the title Print snapshot-id when coldsnap is terminated Print snapshot-id when coldsnap is terminated before finishing upload Apr 20, 2024
@rpkelly
Copy link
Contributor

rpkelly commented May 3, 2024

Hi, could you please clarify the conditions where coldsnap is not returning the snapshot ID? Looking through the errors I'd expect to be thrown on a failed upload return the snapshot-id. Is this in the case of sending a SIGINT while coldsnap is still running?

Would adding a line to the verbose logging that includes the snapshot id as soon as it is created work for what you need? This way that data would always be available, and we wouldn't need to worry about the exit condition for coldsnap.

@rpkelly rpkelly self-assigned this May 7, 2024
@webern webern linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants