Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CBMC validator functions #685

Open
adpaco-aws opened this issue Jan 11, 2021 · 0 comments
Open

Remove CBMC validator functions #685

adpaco-aws opened this issue Jan 11, 2021 · 0 comments
Labels
cbmc CBMC proof related work

Comments

@adpaco-aws
Copy link
Collaborator

There are at least a couple of CBMC validator functions in the code base with names *_is_valid_cbmc. These functions typically do more assumptions than their non-CBMC versions and cannot be used as preconditions in E-SDK functions.

For example, aws_cryptosdk_sig_ctx_is_valid_cbmc was being used in #659 but had to be removed since including it as a precondition to sign_header would require CBMC libraries to be included as well. This is not an option.

The goal is to entirely remove these functions from the code base. To this end, we have to amend proofs where they are being used and then remove their definition (e.g., from cbmc_invariants.c).

@adpaco-aws adpaco-aws added the cbmc CBMC proof related work label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cbmc CBMC proof related work
Projects
None yet
Development

No branches or pull requests

1 participant