Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new scraper jobs for KSH and KCM Metrics #177

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Added new scraper jobs for KSH and KCM Metrics #177

merged 4 commits into from
Jan 8, 2025

Conversation

ashoksrirama
Copy link
Contributor

*Issue #176

Description of changes: Added two jobs to scrape metrics from new EKS endpoints.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elamaran11
Copy link
Contributor

@ashoksrirama This PR looks good at this point, Did you get a chance to send a PR to EKS CDK Blueprints for the Cluster Role Pre-req? @shapirov103 FYI. We would need to do a minor release to support the launch.

@ashoksrirama
Copy link
Contributor Author

Tested with the new eks-blueprints cdk release, able to query the ksh metrics from AMP workspace.
Screenshot 2025-01-07 at 17 25 35
Screenshot 2025-01-07 at 17 30 54

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

4 similar comments
@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

1 similar comment
@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

@elamaran11 elamaran11 closed this Jan 8, 2025
@elamaran11 elamaran11 reopened this Jan 8, 2025
@elamaran11
Copy link
Contributor

/do-e2e-test single-new-eks-opensource-observability deploy

elamaran11
elamaran11 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11 elamaran11 merged commit e17fa0b into aws-observability:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elamaran11 elamaran11 elamaran11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashoksrirama @elamaran11