Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch on ExpirationIntent field in Apple documentation #187

Closed
austinhess opened this issue Mar 8, 2023 · 1 comment
Closed

Mismatch on ExpirationIntent field in Apple documentation #187

austinhess opened this issue Mar 8, 2023 · 1 comment

Comments

@austinhess
Copy link

The SubscriptionNotification ExpirationIntent field is currently marked as an int, unlike the corresponding receipt field, which is a string. The Apple documentation seems to match this at first, listing expiration_intent as an integer here: https://developer.apple.com/documentation/appstoreservernotifications/responsebodyv1, but upon clicking that link for more information, it indicates that it should be a string similar to the receipt. Furthermore, we have logged the raw json body we are getting from Apple in production, and it appears we are still receiving a string for this field in production (usually "", "1", or "2"). So we are unable to proceed with updating our version of go-iap with this ambiguity because we are unsure if this will introduce parsing errors.

It seems the numericString type may be able to handle this case, so would changing ExpirationIntent to that type be appropriate? (If so it may relate to #185)

@richzw
Copy link
Collaborator

richzw commented Apr 14, 2023

@austinhess The type of ExpirationIntent was changed to numericString after v1.3.29.

@richzw richzw closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants