Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio within action fields gets wrong labels #3539

Closed
3 of 8 tasks
pjmuller opened this issue Dec 17, 2024 · 4 comments · Fixed by #3600
Closed
3 of 8 tasks

radio within action fields gets wrong labels #3539

pjmuller opened this issue Dec 17, 2024 · 4 comments · Fixed by #3600
Labels
Bug Something isn't working

Comments

@pjmuller
Copy link

Describe the bug

If I use this code

          field :subscription_state,
                as: :radio,
                name: 'Status',
                options: {
                  proposal: 'Uitnodigen',
                  confirmed: 'Bevestigen',
                  reserve: 'Reserve'
                }

within a resource it works fine
Image

but within an action it doesn't display the labels
Image

(it does have the right keys, so the form sets the right value)

Reproduction repository for the bug

System configuration

Avo version: 3.15.3

Rails version: 7.2

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Impact

  • High impact (It makes my app un-usable.)
  • Medium impact (I'm annoyed, but I'll live.)
  • Low impact (It's really a tiny thing that I could live with.)

Urgency

  • High urgency (I can't continue development without it.)
  • Medium urgency (I found a workaround, but I'd love to have it fixed.)
  • Low urgency (It can wait. I just wanted you to know about it.)
@pjmuller
Copy link
Author

pjmuller commented Dec 17, 2024

Sidenote: BOTH in resource as action -> clicking the label doesn't select the radio (which feels like standard usability best practices)

@pjmuller
Copy link
Author

@adrianthedev and @Paul-Bob (happy late NY ;))

I updated to avo v3.16.1 and the error is still there.
Image

this issue is a blocker for our customers, yet it doesn't feel like this should be done via custom development/billing.

Could you check

  1. if you can reproduce it
  2. if you are able to fix this in in v3.17
  3. if you can do it free of charge

@Paul-Bob Paul-Bob moved this to Next up in Issues Jan 21, 2025
@Paul-Bob Paul-Bob added Bug Something isn't working and removed Stale exempt labels Jan 21, 2025
@Paul-Bob
Copy link
Contributor

Happy new year @pjmuller ! :D

I'll have a look into this, thanks for the reminder

@adrianthedev
Copy link
Collaborator

Yup. It's a bug on our end. we'll have it fixed in no-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants