Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goonj - Changes to API #121

Closed
vinayvenu opened this issue Apr 2, 2024 · 1 comment
Closed

Goonj - Changes to API #121

vinayvenu opened this issue Apr 2, 2024 · 1 comment
Assignees

Comments

@vinayvenu
Copy link
Member

vinayvenu commented Apr 2, 2024

There have been the following changes made in the Goonj implementation - avniproject/Goonj#88 in Goonj Revamp UAT org
Corresponding changes have also been made to the SalesForce API. The purpose of this card is to make necessary changes in the integration-service in order to get integration to work.

The purpose of this story is to make corresponding changes in the integration

Pre-requisite

Salesforce has completed the changes before the new Integration-service changes are deployed

Changes in scope

  • (Testing only) - Change in activity type/subtype/category and measurement type as mentioned in https://docs.google.com/spreadsheets/d/1Hz6frFs1Nj9YPE2ia1E2XlWSIIn_2iVG6GYbnO2tUgE/edit?usp=sharing
  • Distributions form
    • Add fields DisclaimerPhotographs, ReceiverListPhotographs, TotalNumberOfReceivers,
    • Change typeOfCommunity to semicolon separated items since it is now a multiselect (To ensure backwards compatibility, which adds a check for this observation's value and converts single value to array of length one)
    • Remove numberOfDistributions
  • DispatchReceipt
    • Add Remarks
  • Activity
    • Add WasDisclaimerFormFilled (values Yes and No)
    • Add FormCrossChecked (values Yes and No)
    • Change objectiveOfCFWwork to semicolon separated items since it is now a multiselect (For backwards compatibility, we need to create a new concept and add it to the form. On integration service, the values will be picked up from both these concepts)

Testing

  • New changes work
  • Any existing forms work (backwards compatibility when we go live)
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Apr 2, 2024
@vinayvenu vinayvenu moved this from New Issues to In Analysis Review in Avni Product Apr 2, 2024
vedfordev added a commit that referenced this issue Apr 11, 2024
@vedfordev vedfordev moved this from In Analysis Review to In Progress in Avni Product Apr 11, 2024
@vedfordev vedfordev self-assigned this Apr 11, 2024
@vedfordev
Copy link

@vinayvenu Can u check we added total number of receiver in Inventory details section. In Reached to details section also have total number of receiver which is used by ** TotalNumberOfReceivers** .

vedfordev added a commit that referenced this issue Apr 12, 2024
@vinayvenu vinayvenu moved this from In Progress to In Code Review in Avni Product Apr 15, 2024
@vinayvenu vinayvenu moved this from In Code Review to QA Ready in Avni Product Apr 15, 2024
vinayvenu added a commit that referenced this issue Apr 23, 2024
vinayvenu added a commit that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants