Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Day ranges through Sunday #31

Closed
skewwhiffy opened this issue Aug 29, 2017 · 1 comment
Closed

Day ranges through Sunday #31

skewwhiffy opened this issue Aug 29, 2017 · 1 comment

Comments

@skewwhiffy
Copy link

Failing test here: https://github.com/skewwhiffy/NCrontab/blob/DayRangeIssue/NCrontab.Tests/CrontabScheduleTests.cs#L381

A day range like SAT-MON is treated as an inverted range 6-1, rather than SAT,SUN,MON.

#25 is probably linked: certainly disallowing such ranges would be better behaviour than treating it as an inverted range.

Happy to try and fix this, just let me know.
@atifaziz
Copy link
Owner

#25 is probably linked: certainly disallowing such ranges would be better behaviour than treating it as an inverted range.

Yes, #25 is the real issue/resolution so I'll close this and we can continue any discussion over at #25.

@atifaziz atifaziz mentioned this issue Aug 29, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atifaziz @skewwhiffy