Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDSS to Prominently Feature DR17 #2365

Closed
jsobeck opened this issue Apr 15, 2022 · 9 comments · Fixed by #2478
Closed

Update SDSS to Prominently Feature DR17 #2365

jsobeck opened this issue Apr 15, 2022 · 9 comments · Fixed by #2478
Labels

Comments

@jsobeck
Copy link
Contributor

jsobeck commented Apr 15, 2022

Would it be possible to update the astroquery sdss module to default to the most recent data release of SDSS, DR17. The main change should occur here: https://github.com/astropy/astroquery/blob/main/astroquery/sdss/__init__.py. I could do a quick PR for this (and it could merged with admin approval). Thank you for your help.

@bsipocz bsipocz added the sdss label Apr 15, 2022
@bsipocz
Copy link
Member

bsipocz commented Apr 15, 2022

I would be OK with changing the default, but paging the others, here, too. Let's wait for their input before you open a PR.

@weaverba137 @keflavich - would you prefer to change the default? This would certainly mean necessary changes to the docs and tests, so certainly is a bit more involved than changing the int in the init.

@keflavich
Copy link
Contributor

I have no objection. Is DR17 inclusive of previous data releases? If so, it seems that it would make the most sense to update to the latest when it's available.

@jsobeck
Copy link
Contributor Author

jsobeck commented Apr 18, 2022

The answer to this question is yes (but there is some nuance). The final acquisition of imaging data occurred in 2009 while the final spectroscopic data were taken in 2021. DR17 is inclusive of all spectroscopic data from SDSS (see the publicly accessible site here: https://data.sdss.org/sas/dr17/). The DR17 release also contains all prior imaging data (see https://www.sdss.org/dr17/imaging/; note that the imaging data were frozen in an earlier release). The SAS and Skyserver sites, which serve as access points for astroquery, appropriately direct users.

@weaverba137
Copy link
Member

I second what @jsobeck said. I am available to assist & review as needed.

@jsobeck
Copy link
Contributor Author

jsobeck commented Apr 25, 2022

So, I'll do a quick PR and you all can vet/approve it when you have a spare second. Sound alright?

@bsipocz
Copy link
Member

bsipocz commented Apr 25, 2022

@jsobeck - that sounds like a good plan. Please do run the remote tests for the module, too to make sure all those are fixed in the PR, as CI is not running them: python setup.py -P sdss -R

@weaverba137
Copy link
Member

I suggest incorporating changes from #2477, unless a PR for this has already been submitted?

@bsipocz
Copy link
Member

bsipocz commented Aug 2, 2022

There is no PR open yet, so please feel free to go ahead and include this in #2477.

@jsobeck
Copy link
Contributor Author

jsobeck commented Aug 2, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants