-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use keyword only arguments #1746
Comments
OK, so a lot of time has passed, and we moved a significant fraction of the modules to use keyword-only arguments. I would propose to try to make this change for all the modules for the next release. |
@ceb8 @keflavich - It would be nice to go through this list for the next tagged release. Technically the changes are trivial, we only need to be careful to also change the tests and docs. |
This is now almost fully done, the only modules remaining are having their own issues, and tracked separately, or are already deprecated for removal. Enormous thanks to @nkphysics! |
Many functionalities in astroquery have numerous arguments. Many of those are optional kwarg atm, and I propose to switch to to be kwarg only. I think that would help
We've seen several cases in the past where adding new kwargs ended in awkwardness as they needed to be added to the last position to keep the API backwards compatible for position arg usage.
astroquery.mast
methods take explicit kwargs #2317 This issue highlights that there are still todo for mast: DOC: make signatures more explicit in MAST docstrings #2665The text was updated successfully, but these errors were encountered: