Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyword only arguments #1746

Closed
59 of 62 tasks
bsipocz opened this issue Jun 18, 2020 · 3 comments
Closed
59 of 62 tasks

Use keyword only arguments #1746

bsipocz opened this issue Jun 18, 2020 · 3 comments
Labels
Milestone

Comments

@bsipocz
Copy link
Member

bsipocz commented Jun 18, 2020

Many functionalities in astroquery have numerous arguments. Many of those are optional kwarg atm, and I propose to switch to to be kwarg only. I think that would help

We've seen several cases in the past where adding new kwargs ended in awkwardness as they needed to be added to the last position to keep the API backwards compatible for position arg usage.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 9, 2022

OK, so a lot of time has passed, and we moved a significant fraction of the modules to use keyword-only arguments. I would propose to try to make this change for all the modules for the next release.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 26, 2022

@ceb8 @keflavich - It would be nice to go through this list for the next tagged release. Technically the changes are trivial, we only need to be careful to also change the tests and docs.

@bsipocz
Copy link
Member Author

bsipocz commented Apr 28, 2023

This is now almost fully done, the only modules remaining are having their own issues, and tracked separately, or are already deprecated for removal.

Enormous thanks to @nkphysics!

@bsipocz bsipocz closed this as completed Apr 28, 2023
@bsipocz bsipocz unpinned this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant