Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrinking box size towards the celestial poles? #1088

Closed
shiaki opened this issue Apr 4, 2018 · 2 comments
Closed

shrinking box size towards the celestial poles? #1088

shiaki opened this issue Apr 4, 2018 · 2 comments

Comments

@shiaki
Copy link

shiaki commented Apr 4, 2018

% (ra - dr, ra + dr, dec - dr, dec + dr))

I think using "(ra - dr / cos_dec, ra + dr / cos_dec, ..." is better. Otherwise the actual box size will shrink towards the celestial poles. Also, adding boundary detection near RA~0/360 might be helpful.

I've been using astroquery for a while, which helped a lot in my research. Thanks anyway!

@keflavich keflavich added the sdss label Apr 4, 2018
@bsipocz bsipocz added the bug label Apr 5, 2018
@bsipocz
Copy link
Member

bsipocz commented Apr 5, 2018

Actually it would be good to get rid of this workaround and use what sdss does with their radius search:

SELECT  TOP 10 p.objid,
   p.run, p.rerun, p.camcol, p.field, p.obj,
   p.type, p.ra, p.dec, p.u,p.g,p.r,p.i,p.z,
   p.Err_u, p.Err_g, p.Err_r,p.Err_i,p.Err_z
   FROM fGetNearbyObjEq(258.25,64.05,3) n,   PhotoPrimary p
   WHERE n.objID=p.objID 

alternatively define a dr_ra and dr_dec separately and use that one.

@bsipocz
Copy link
Member

bsipocz commented Sep 11, 2022

PR #2477 has refactored this piece of code to use the SDSS conesearch API, so I'm closing this now.

@bsipocz bsipocz closed this as completed Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants