Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog.crossmatch does not raise for unknown kwargs #293

Closed
2 of 3 tasks
hombit opened this issue Apr 25, 2024 · 0 comments · Fixed by #301
Closed
2 of 3 tasks

Catalog.crossmatch does not raise for unknown kwargs #293

hombit opened this issue Apr 25, 2024 · 0 comments · Fixed by #301
Labels
bug Something isn't working

Comments

@hombit
Copy link
Contributor

hombit commented Apr 25, 2024

Bug report

Catalog.crossmatch() doesn't raise an exception for unknown arguments, it is very inconvenient for the cases when user makes a typo in an argument name, for example cat1.crossmatch(cat2, radius_arcsecond=1.2, neigbours=3) instead of cat1.crossmatch(cat2, radius_arcsec=1.2, n_neighbors=3).

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant