Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all pokemons fetchable by name #29

Open
Mehul343 opened this issue Oct 17, 2021 · 3 comments
Open

Not all pokemons fetchable by name #29

Mehul343 opened this issue Oct 17, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@Mehul343
Copy link

There are some pokemons for which you can't get the data by searching by their name for example keldeo, deoxys, mimikyu. But you can get their data by their dex number.

@arnavb arnavb self-assigned this May 8, 2023
@arnavb
Copy link
Owner

arnavb commented May 8, 2023

Hey @Mehul343, this seems to be an issue with how PokeAPI handles different forms; in the case of Keldeo, you could try keldeo-ordinary or keldeo-resolute. There's more detail in PokeAPI/pokeapi#401. This library doesn't really concern itself with the details of the Pokemon itself, so it's not an issue I can readily solve.

@arnavb arnavb closed this as completed May 8, 2023
@arnavb arnavb added question Further information is requested wontfix This will not be worked on labels May 8, 2023
@d0rf47
Copy link

d0rf47 commented May 12, 2023

There are some pokemons for which you can't get the data by searching by their name for example keldeo, deoxys, mimikyu. But you can get their data by their dex number.

Yea this is an issue with several pokemon. As far as i am able to tell i think the best bet is to fetch a Species Resource via name and use the response ID to fetch the pokemon resource by ID. This seems the most consistent way to get a reliable result.

@arnavb
Copy link
Owner

arnavb commented May 19, 2023

... As far as i am able to tell i think the best bet is to fetch a Species Resource via name and use the response ID to fetch the pokemon resource by ID...

Ah, this is an interesting idea, @d0rf47, it might be worth implementing as an extra API function.

I'm not entirely sure what the best way of going about that would be, so I'm open to any new ideas here.

@arnavb arnavb reopened this May 19, 2023
@arnavb arnavb added enhancement New feature or request help wanted Extra attention is needed and removed wontfix This will not be worked on labels May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants