Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add comment under Ethernet Interfaces and Port-Channel interfaces #4864

Open
1 task done
gmuloc opened this issue Jan 9, 2025 · 0 comments
Open
1 task done
Assignees
Labels
type: enhancement New feature or request

Comments

@gmuloc
Copy link
Contributor

gmuloc commented Jan 9, 2025

Enhancement summary

Add the two following keys in schema as a preparatory step for #4672

ethernet_interfaces:
  - name: Ethernet1
    comment: foo
port_channel_interfaces:
  - name: Port-Channel42
    comment: foo

Reuse the qos_profiles

Which component of AVD is impacted

eos_cli_config_gen

Use case example

Add a comment under ethernet interfaces / port-channel interfaces showing up in the EOS config

Describe the solution you would like

cf summary for where it should located

the eos template should look like this (from python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/qos-profiles.j2)

{%         if mc_tx_queue.comment is arista.avd.defined %}
{%             for comment_line in mc_tx_queue.comment.splitlines() | arista.avd.default([]) %}
      !! {{ comment_line }}
{%             endfor %}
{%         endif %}

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

  • I agree to follow this project's Code of Conduct
@gmuloc gmuloc added the type: enhancement New feature or request label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants