From 5dd1302a93822de66b216bdd5293b110eeda75c8 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 13:26:53 +0900 Subject: [PATCH 01/16] fix: workflow release please --- .github/workflows/jest-testing.yml | 5 ++++- .github/workflows/release-please.yml | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index a7e36fad..6a0f6721 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -3,7 +3,10 @@ on: workflow_dispatch: pull_request_target: types: [opened, synchronize] - + workflow_run: + workflows: ["Build"] + types: + - completed env: NODE_ENV: "test" diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index a5b40f7b..1572eebf 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: push: branches: - - $default-branch + - ${{ github.event.repository.default_branch }} permissions: contents: write @@ -17,7 +17,7 @@ jobs: - uses: google-github-actions/release-please-action@v3 with: release-type: node - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: node-version: "20.10.0" From 0499dcbe14472c86b0a50169a86f2e6282d6c323 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 13:29:30 +0900 Subject: [PATCH 02/16] fix: workflow cypress --- .github/workflows/cypress-testing.yml | 6 ++++-- .github/workflows/jest-testing.yml | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cypress-testing.yml b/.github/workflows/cypress-testing.yml index 1cf9d5a6..552e8f0a 100644 --- a/.github/workflows/cypress-testing.yml +++ b/.github/workflows/cypress-testing.yml @@ -1,8 +1,10 @@ name: Run Cypress testing suite on: workflow_dispatch: - pull_request: - types: [opened, synchronize] + workflow_run: + workflows: ["Build"] + types: + - completed jobs: cypress-run: diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 6a0f6721..201c7681 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -1,8 +1,6 @@ name: Run Jest testing suite on: workflow_dispatch: - pull_request_target: - types: [opened, synchronize] workflow_run: workflows: ["Build"] types: From 0bf1b4378863aeb0227145d47eb87c427787191f Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 13:37:23 +0900 Subject: [PATCH 03/16] chore: test reporting lib --- .github/workflows/jest-testing.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 201c7681..da4421d7 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -19,16 +19,16 @@ jobs: - uses: actions/checkout@master with: fetch-depth: 0 - - name: Build & Run test suite - run: | - yarn - yarn test | tee ./coverage.txt && exit ${PIPESTATUS[0]} +# - name: Build & Run test suite +# run: | +# yarn +# yarn test | tee ./coverage.txt && exit ${PIPESTATUS[0]} - name: Jest Coverage Comment # Ensures this step is run even on previous step failure (e.g. test failed) if: always() - uses: MishaKav/jest-coverage-comment@main - with: - coverage-summary-path: coverage/coverage-summary.json - junitxml-path: junit.xml - junitxml-title: JUnit - coverage-path: ./coverage.txt + uses: ArtiomTr/jest-coverage-report-action@v2 +# with: +# coverage-summary-path: coverage/coverage-summary.json +# junitxml-path: junit.xml +# junitxml-title: JUnit +# coverage-path: ./coverage.txt From d9acdb0090e3d87d3b75dfdc47aca0b28d6d5d3b Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 13:42:58 +0900 Subject: [PATCH 04/16] chore: test reporting lib --- .github/workflows/jest-testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index da4421d7..30ac0050 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -27,7 +27,7 @@ jobs: # Ensures this step is run even on previous step failure (e.g. test failed) if: always() uses: ArtiomTr/jest-coverage-report-action@v2 -# with: +# with: testing # coverage-summary-path: coverage/coverage-summary.json # junitxml-path: junit.xml # junitxml-title: JUnit From fd14c9e0b1e4c9693fd9f70c149626bb470fc7fc Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 13:52:27 +0900 Subject: [PATCH 05/16] chore: test reporting lib --- .github/workflows/jest-testing.yml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 30ac0050..196fac9e 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -19,16 +19,9 @@ jobs: - uses: actions/checkout@master with: fetch-depth: 0 -# - name: Build & Run test suite -# run: | -# yarn -# yarn test | tee ./coverage.txt && exit ${PIPESTATUS[0]} - - name: Jest Coverage Comment + - name: Jest With Coverage Comment # Ensures this step is run even on previous step failure (e.g. test failed) if: always() uses: ArtiomTr/jest-coverage-report-action@v2 -# with: testing -# coverage-summary-path: coverage/coverage-summary.json -# junitxml-path: junit.xml -# junitxml-title: JUnit -# coverage-path: ./coverage.txt + with: + package-manager: yarn From befe97f5eb8e75a19e79b3e5a167a7b0369c4a50 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 13:59:21 +0900 Subject: [PATCH 06/16] chore: test reporting lib --- .github/workflows/jest-testing.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 196fac9e..966c7022 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -1,10 +1,12 @@ name: Run Jest testing suite on: workflow_dispatch: - workflow_run: - workflows: ["Build"] - types: - - completed + pull_request_target: +# workflow_run: +# workflows: ["Build"] +# types: +# - completed + env: NODE_ENV: "test" From 4af0e66d5ddd8ee482cb77c0a1b65ca39aa4d302 Mon Sep 17 00:00:00 2001 From: Mentlegen <9807008+gentlementlegen@users.noreply.github.com> Date: Mon, 3 Jun 2024 13:59:25 +0900 Subject: [PATCH 07/16] Update jest-testing.yml --- .github/workflows/jest-testing.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 196fac9e..ca88303d 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -1,10 +1,8 @@ name: Run Jest testing suite on: workflow_dispatch: - workflow_run: - workflows: ["Build"] - types: - - completed + pull_request_target: + env: NODE_ENV: "test" From a45d97662d390ca3a17e390752225248370980d8 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:06:10 +0900 Subject: [PATCH 08/16] chore: find PR number --- .github/workflows/jest-testing.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 966c7022..3d1db3f4 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -21,9 +21,12 @@ jobs: - uses: actions/checkout@master with: fetch-depth: 0 + - uses: jwalton/gh-find-current-pr@v1 + id: findPr - name: Jest With Coverage Comment # Ensures this step is run even on previous step failure (e.g. test failed) if: always() uses: ArtiomTr/jest-coverage-report-action@v2 with: package-manager: yarn + prnumber: ${{ steps.findPr.outputs.number }} From 6b9fa4f8fdad91d26cd7b721c2d563fee6d128e1 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:07:00 +0900 Subject: [PATCH 09/16] chore: remove event --- .github/workflows/jest-testing.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 3d1db3f4..55b4779a 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -1,11 +1,10 @@ name: Run Jest testing suite on: workflow_dispatch: - pull_request_target: -# workflow_run: -# workflows: ["Build"] -# types: -# - completed + workflow_run: + workflows: ["Build"] + types: + - completed env: NODE_ENV: "test" From dee52359553cb126f2bb9f4f496ea6eff8d889c3 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:14:02 +0900 Subject: [PATCH 10/16] chore: test pr number --- .github/workflows/jest-testing.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 55b4779a..8995ec1a 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -17,11 +17,14 @@ jobs: - uses: actions/setup-node@v4 with: node-version: "20.10.0" + - uses: actions/checkout@master with: fetch-depth: 0 + - uses: jwalton/gh-find-current-pr@v1 id: findPr + - name: Jest With Coverage Comment # Ensures this step is run even on previous step failure (e.g. test failed) if: always() From b3505f7bac065baa0999bc62de7b7f5ec875c227 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:22:31 +0900 Subject: [PATCH 11/16] chore: test pr number --- .github/workflows/jest-testing.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 55b4779a..8e7886e8 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -1,10 +1,7 @@ name: Run Jest testing suite on: workflow_dispatch: - workflow_run: - workflows: ["Build"] - types: - - completed + pull_request_target: env: NODE_ENV: "test" @@ -17,15 +14,15 @@ jobs: - uses: actions/setup-node@v4 with: node-version: "20.10.0" + - uses: actions/checkout@master with: fetch-depth: 0 - - uses: jwalton/gh-find-current-pr@v1 - id: findPr + - name: Jest With Coverage Comment # Ensures this step is run even on previous step failure (e.g. test failed) if: always() uses: ArtiomTr/jest-coverage-report-action@v2 with: package-manager: yarn - prnumber: ${{ steps.findPr.outputs.number }} + prnumber: ${{ github.event.pull_request.number || github.event.workflow_run.pull_requests[0].number }} From ad1d7c488b6ecb7518be386d15e36d13d0097f99 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:26:17 +0900 Subject: [PATCH 12/16] chore: test pr number --- .github/workflows/jest-testing.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 8e7886e8..6b432ecf 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -1,7 +1,10 @@ name: Run Jest testing suite on: workflow_dispatch: - pull_request_target: + workflow_run: + workflows: ["Build"] + types: + - completed env: NODE_ENV: "test" From e219ea0a11bfbf76eeaac9e3aa8faa0209faa7c2 Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:30:54 +0900 Subject: [PATCH 13/16] chore: test comment --- .github/workflows/jest-testing.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index 8e7886e8..fc47277a 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -26,3 +26,5 @@ jobs: with: package-manager: yarn prnumber: ${{ github.event.pull_request.number || github.event.workflow_run.pull_requests[0].number }} + +# comment From fe828f4aaab25daed897aa749836b4120c583d4a Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:35:14 +0900 Subject: [PATCH 14/16] chore: test comment --- .github/workflows/jest-testing.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index fc47277a..8e7886e8 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -26,5 +26,3 @@ jobs: with: package-manager: yarn prnumber: ${{ github.event.pull_request.number || github.event.workflow_run.pull_requests[0].number }} - -# comment From 720b09156394cffccb431ec68c3a0b81222d3f7f Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:52:45 +0900 Subject: [PATCH 15/16] chore: revert default branch for release-please.yml --- .github/workflows/release-please.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 1572eebf..a2dc24e9 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: push: branches: - - ${{ github.event.repository.default_branch }} + - $default-branch permissions: contents: write From 16b30902cf06d86d24826dbebb4d21be62156d2b Mon Sep 17 00:00:00 2001 From: gentlementlegen Date: Mon, 3 Jun 2024 14:56:20 +0900 Subject: [PATCH 16/16] chore: revert default branch for release-please.yml --- .github/workflows/release-please.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index a2dc24e9..5c626001 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: push: branches: - - $default-branch + - main permissions: contents: write