-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Music omits last pattern of song #457
Comments
As a quick check I printed out the length of the converted audio but it seems to match between platforms:
e.g. Yesterday should be (14405632 ÷ (44100 × 2 × 2)) = 81.66 seconds long on both platforms. |
I don’t think this is Windows-specific. I hear a pause at the end of tracks on Mac too. |
There seems to be a problem with libmodplug where 6 bytes are required after the last pattern or else it will be dropped. Reported as Konstanty/libmodplug#95, but I for now I’ll just add padding to the Antares data. |
With these changes the lengths I see are:
|
Apparently sections of the music are dropped, particularly at the beginning/end of the loop.
Not clear if the problem is in the libmodplug renderer or in the XAudio2 driver.
The text was updated successfully, but these errors were encountered: