Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run Forge 1.16.5 in dev env #45

Open
ThexXTURBOXx opened this issue Apr 26, 2024 · 2 comments
Open

Cannot run Forge 1.16.5 in dev env #45

ThexXTURBOXx opened this issue Apr 26, 2024 · 2 comments

Comments

@ThexXTURBOXx
Copy link
Contributor

ThexXTURBOXx commented Apr 26, 2024

I am currently trying to migrate a 1.16.5 mod to Architectury and for debugging, it would be very nice to be able to use the generated Architectury run configurations in IntelliJ.
However, as soon as the Minecraft client gets to the main menu, it crashes. Here is my log: https://paste.ee/p/BBmj0
I am unsure what the exact cause of this issue is - probably either something that went wrong during transformation (in this case: sorry - I will reopen this issue in the architectury-transformer repo) or something inside the architectury-plugin went wrong.
What I have tried so far: gradlew clean, gradlew --refresh-dependencies, invaliding caches in IntelliJ, completely deleting the .idea folder manually and reinitialising the project

Also, gradlew forge:runClient yields exactly the same error.
I should also mention: I only tried with the Minecraft Client (Forge) configuration yet - there are some issues I want to resolve first before even attempting to start Fabric

Edit: I am using Architectury Loom 1.6 - maybe this could also be part of the issue

@ThexXTURBOXx ThexXTURBOXx changed the title Cannot run 1.16.5 in dev env Cannot run Forge 1.16.5 in dev env Apr 26, 2024
@ThexXTURBOXx
Copy link
Contributor Author

ThexXTURBOXx commented Apr 26, 2024

Did some more experimenting and found out that this is indeed only an issue in my Forge module as Fabric works without any problems.
Just for test purposes, I ran the genSources task to see what the decompiler says and this is the result:
grafik

Indeed, as seen in the bottom right corner, func_227987_b_ is not remapped properly.
I am using Parchment mappings as described in Architectury's documentation - maybe this is also part of the issue?

And there are even more occurrences in the same file which have not been remapped:
grafik

@ThexXTURBOXx
Copy link
Contributor Author

Finally found a fix: I used Forge 1.16.5-36.2.42 before, which is the latest version.
However, I noticed that it is not the recommended version. Hence, downgrading to 1.16.5-36.2.34 fixed the problem.
Looking at the changelog, I found the following two entries in 1.16.5-36.2.41:

  • Apply official mappings to patches (still using MCP classnames)
  • Rename TransformationMatrix methods to prevent reobf, add back vanilla name via coremod

Probably one of these caused the problem I ran into - however I won't bother trying out different versions for now.
If someone else coincidentally runs into this very issue, just downgrade to the recommended version and you should be fine.
I will leave this open for now. If someone wants to close this issue, feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant