Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUNCTION_LOCATIONS, ETL_MODULE_LOCATIONS, etc don't account for arches applications #10288

Closed
jacobtylerwalls opened this issue Nov 21, 2023 · 3 comments · Fixed by #10613
Closed
Assignees

Comments

@jacobtylerwalls
Copy link
Member

dev/7.5.x

  1. Create an arches application with a function at pkg/extensions/functions/foo.py
  2. Create an app that installs app 1 as an arches application
  3. Plugin will be registered to app2's db, but will never be found at runtime without manipulating app2's FUNCTION_LOCATIONS to include app1.pkg.extensions.functions.

Suggesting an enhancement where whatever reads from FUNCTION_LOCATIONS is smart enough to get the function from the installed arches applications (probably discovering in whatever order the apps are defined in ARCHES_APPLICATIONS) instead of requiring additional configuration in app2.

Probably affects these also, but haven't checked:

  • DATATYPE_LOCATIONS
  • ETL_MODULE_LOCATIONS
  • SEARCH_COMPONENT_LOCATIONS
@chiatt chiatt added this to pipeline Nov 21, 2023
@chiatt
Copy link
Member

chiatt commented Nov 21, 2023

This change would probably need to be made to arches/app/utils/module_importer.py

@jacobtylerwalls jacobtylerwalls changed the title FUNCTION_LOCATIONS doesn't account for installed arches applications FUNCTION_LOCATIONS, ETL_MODULE_LOCATIONS, etc don't account for arches applications Jan 26, 2024
@jacobtylerwalls
Copy link
Member Author

@robgaston FYI this came up last week with @johnatawnclementawn and just now with @aarongundel.

@jacobtylerwalls jacobtylerwalls self-assigned this Feb 13, 2024
@jacobtylerwalls jacobtylerwalls moved this to 🔖 Ready in pipeline Feb 13, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In Progress in pipeline Feb 16, 2024
@jacobtylerwalls jacobtylerwalls linked a pull request Feb 16, 2024 that will close this issue
6 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Feb 16, 2024
jacobtylerwalls added a commit that referenced this issue Feb 16, 2024
jacobtylerwalls added a commit that referenced this issue Feb 21, 2024
robgaston added a commit that referenced this issue Mar 6, 2024
…hes-apps

Detect python extensions in arches apps #10288
@jacobtylerwalls
Copy link
Member Author

Fixed in #10613

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Mar 6, 2024
chiatt pushed a commit that referenced this issue Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants