Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default report template shows the separator line even when the card is not visible #10219

Closed
njkim opened this issue Oct 31, 2023 · 0 comments · Fixed by #10221
Closed

The default report template shows the separator line even when the card is not visible #10219

njkim opened this issue Oct 31, 2023 · 0 comments · Fixed by #10221
Assignees
@njkim

Comments

@njkim
Copy link
Collaborator

njkim commented Oct 31, 2023 •
edited
Loading

The default report template shows the separator line even when the card is not visible.
So, if you have invisible cards (with the tile data), only the separator will show and result in separator with no contents.

It typically only happens when the card is invisible but grouped with other card in a grouping card, so the invisible card can have a tile data.
@chiatt chiatt added this to pipeline Oct 31, 2023
@njkim njkim self-assigned this Oct 31, 2023
@njkim njkim moved this to 🏗 In Progress in pipeline Oct 31, 2023
njkim added a commit that referenced this issue Oct 31, 2023
@njkim
Hide the separtor line for invisible card, #10219
7b3adfc
@njkim njkim mentioned this issue Oct 31, 2023
Merged
6 tasks
@chiatt chiatt linked a pull request Nov 2, 2023 that will close this issue
Hide the separator line for invisible card, #10219 #10221
Merged
6 tasks
chrabyrd added a commit that referenced this issue Nov 9, 2023
@chrabyrd
nit #10219
b1752a7
chrabyrd added a commit that referenced this issue Nov 9, 2023
@chrabyrd
Merge pull request #10221 from archesproject/10219_hide_line_for_invi…
b60b59a 
…sible_card

Hide the separator line for invisible card, #10219
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in pipeline Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njkim njkim

Labels
None yet
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide the separator line for invisible card, #10219 archesproject/arches
2 participants
@njkim @jacobtylerwalls