Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition in concept-select.js #10162

Closed
aarongundel opened this issue Sep 18, 2023 · 3 comments · Fixed by #10163
Closed

Race condition in concept-select.js #10162

aarongundel opened this issue Sep 18, 2023 · 3 comments · Fixed by #10163
Assignees
Labels

Comments

@aarongundel
Copy link
Contributor

There's a bug in project statements. It appears to be related to concepts.

1.) Create a new project with the new project workflow. Add a statement in step 2.
2) View this project resource in the UI. Click on "Statement About Project". You'll see

Cannot read properties of null (reading 'find')
TypeError: Cannot read properties of null (reading 'find')
@aarongundel
Copy link
Contributor Author

aarongundel commented Sep 18, 2023

Something very similar seems to be happening in Sampling Activity / Name and Sampling Activity / Statement

@aarongundel
Copy link
Contributor Author

Looked at this with @chrabyrd - this has probably been happening for some time, and is likely due to some kind of duplicative calls to the API. They do not appear to be causing breakage at this point. The easiest workaround is to disable the devServer.client.overlay in webpack.config.dev.js by setting it to false. The errors still happen, but they don't stop anything from working.

@jacobtylerwalls jacobtylerwalls transferred this issue from archesproject/arches-for-science Oct 19, 2023
@jacobtylerwalls jacobtylerwalls changed the title Bug with Project Statement Race condition in concept-select.js Oct 19, 2023
@chiatt chiatt added this to pipeline Oct 19, 2023
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In Progress in pipeline Oct 19, 2023
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Oct 19, 2023
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in afs-pipeline Oct 19, 2023
chrabyrd added a commit that referenced this issue Oct 24, 2023
…race

Fix race condition in concept select widget #10162
@chrabyrd
Copy link
Contributor

resolved in #10163

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in afs-pipeline Oct 24, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants