Adds note editor (#177) #181
Open
+409
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrabyrd
reviewed
Jan 9, 2025
chrabyrd
approved these changes
Jan 16, 2025
| @@ -16,6 +16,7 @@ | |||
| api_scheme_label_create="{% url 'api-scheme-label-create' %}" | |||
| api_scheme_note='(resourceid)=>{return "{% url "api-scheme-note" "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa" %}".replace("aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa", resourceid)}' | |||
| api_scheme_note_tile='(resourceid, tileid)=>{return "{% url "api-scheme-note-tile" "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa" "aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaab" %}".replace("aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa", resourceid).replace("aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaab", tileid)}' | |||
| api_scheme_note_create="{% url 'api-scheme-note-create' %}" | |||
There was a problem hiding this comment.
should this just fall under the api_scheme_note as a different verb?
There was a problem hiding this comment.
It looks like it, but that doesn't actually work. The difference is in pythonic_models.py - you'll see there are different views used for these routes. The ListCreateView is necessary here because we're dealing with a list of tiles. If I was to try a patch or a put against api_scheme_note (which uses RetrieveUpdateDestroyAPIView) I'd blow away the rest of the list.
aarongundel
force-pushed
the
adg/177-scheme-notes
branch
from
ea2ee2c to
8895e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.