Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Please consider to remove harbor-helmsubmodule related file while create a new tag release #501

Open
MinerYang opened this issue Jul 16, 2024 · 5 comments

Comments

@MinerYang
Copy link

What steps did you take and what happened:

AFAK, the harbor-helm submodule is only used while developing not something for build. So while it shipped with a tag/branch, somehow would cause trouble for our internal build process.
A little bit more contexts here is , we are not allowed to pull repository from outside(means, opensource repository), and once we tried to remove or update the submodule related file, this tag release would become a dirty commit which is also not allowed.

What did you expect to happen:
Please consider to remove harbor-helmsubmodule related file while create a new tag release, including:

@knqyf263
Copy link
Collaborator

Our release files don't include them.

$ tar tvf harbor-scanner-trivy_0.31.3_Linux_x86_64.tar.gz
-rw-r--r--  0 runner docker  11357  6 26 11:55 LICENSE
-rw-r--r--  0 runner docker  26039  6 26 11:55 README.md
-rwxr-xr-x  0 runner docker 9900184  6 26 11:58 scanner-trivy

@MinerYang
Copy link
Author

MinerYang commented Jul 16, 2024

Hi @knqyf263 ,

It is not the binary tarball you build and published for use. We need to somehow build from source on our own.
And as there are some limitations within our internal building process states as above. Would appreciate a lot if you could help to remove these files when creating a new branch/tag next time, for example v0.31.4. That would be a more tidy way for us, otherwise, I need to do some extra dirty work to bypassing this issue.

Best,
Miner

@knqyf263
Copy link
Collaborator

What if deleting them when you build it?

@MinerYang
Copy link
Author

Yes, that's exactly what I tried before.
Unfortunately, this is not possible for us cause this harbor-scanner-trivy repo has already been a submodule of our src building repository, now the harbor-helm in this situation would be a submodule of submodule. If I tried to modify these, that would be a dirty commit, and this is not allowed from our building process.

@knqyf263
Copy link
Collaborator

The submodule is used for skaffold here. Our requirement is just running Harbor and the adapter with skaffold. Please feel free to open a PR updating skaffold.yaml and deleting the submodule.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants