Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info.apiURL property in published pom.xml is not consistent #952

Closed
raboof opened this issue Jan 14, 2025 · 3 comments
Closed

info.apiURL property in published pom.xml is not consistent #952

raboof opened this issue Jan 14, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@raboof
Copy link
Member

raboof commented Jan 14, 2025

The info.apiURL property is not consistently populated in the published pom.xmls: for example https://repo1.maven.org/maven2/org/apache/pekko/pekko-connectors-amqp_2.12/1.1.0-M1/pekko-connectors-amqp_2.12-1.1.0-M1.pom links to https://pekko.apache.org/api/pekko-connectors/1.1.0-M1/ while
https://repository.apache.org/content/groups/staging/org/apache/pekko/pekko-connectors-amqp_2.12/1.1.0/pekko-connectors-amqp_2.12-1.1.0.pom refers to https://pekko.apache.org/api/pekko-connectors/current (but the same build on my local machine puts a version in there instead of current).

I think we don't have strong feelings which is better, but we want it to be consistent across independent builds.

@raboof raboof added the bug Something isn't working label Jan 14, 2025
@pjfanning
Copy link
Contributor

I think this was caused by me modifying the .jvmopts file locally because I was running into heap memory issues when running sbt +publishSigned.

See

apiURL := {
val apiVersion = if (isSnapshot.value) "current" else version.value
Some(url(s"https://pekko.apache.org/api/pekko-connectors/$apiVersion/"))
},

I added #943 which helps a bit. So future releases may not run into this issue.

@pjfanning
Copy link
Contributor

pjfanning commented Jan 15, 2025

I rebuilt the 1.1.0 artifacts before calling for developers to review the 1.1.0 jars - so the poms for 1.1.0 have 1.1.0 in their URLs.

@raboof
Copy link
Member Author

raboof commented Jan 16, 2025

still surprising as I'd expect isSnapshot.value to be false even when the git checkout is dirty... but fine to close this, indeed the 1.1.0 have the expected apiURL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants