Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit use of AtomicInt32 and AtomicInt64 methods #917

Closed
1 task done
paulirwin opened this issue Feb 24, 2024 · 0 comments · Fixed by #927
Closed
1 task done

Audit use of AtomicInt32 and AtomicInt64 methods #917

paulirwin opened this issue Feb 24, 2024 · 0 comments · Fixed by #927
Assignees
@NightOwl888
Labels
is:task A chore to be done

Comments

@paulirwin
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Task description

Context: #914 (comment)

From @NightOwl888:

at one point the method [GetAndAdd] didn't exist, we should do a sweep to ensure that all calls to GetAndAdd(), AddAndGet(), IncrementAndGet(), GetAndIncrement(), DecrementAndGet(), and GetAndDecrement() match Lucene (for both AtomicInt32 and AtomicInt64). We may not have caught this everywhere it matters.
@paulirwin paulirwin added the is:task A chore to be done label Feb 24, 2024
@paulirwin paulirwin mentioned this issue Feb 24, 2024
Merged
4 tasks
@NightOwl888 NightOwl888 self-assigned this Mar 10, 2024
NightOwl888 added a commit to NightOwl888/lucenenet that referenced this issue Mar 10, 2024
@NightOwl888
SWEEP: Reviewed all applications of .IncrementAndGet(), .GetAndIncrem…
cd79a44 
…ent(), .DecrementAndGet(), and .GetAndDecrement() from atomic numeric classes. Closes apache#917.
@NightOwl888 NightOwl888 mentioned this issue Mar 10, 2024
Merged
4 tasks
NightOwl888 added a commit that referenced this issue Mar 11, 2024
@NightOwl888
SWEEP: Reviewed usage of atomic numeric type methods (#927)
63e1053 
* SWEEP: Reviewed all applications of .AddAndGet() methods from atomic numeric classes

* SWEEP: Reviewed all applications of .GetAndAdd() methods from atomic numeric classes

* SWEEP: Reviewed all applications of .IncrementAndGet(), .GetAndIncrement(), .DecrementAndGet(), and .GetAndDecrement() from atomic numeric classes. Closes #917.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NightOwl888 NightOwl888

Labels
is:task A chore to be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SWEEP: Reviewed usage of atomic numeric type methods NightOwl888/lucenenet
2 participants
@NightOwl888 @paulirwin