Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] velox configuration names aren't identical #8404

Closed
FelixYBW opened this issue Jan 2, 2025 · 2 comments
Closed

[VL] velox configuration names aren't identical #8404

FelixYBW opened this issue Jan 2, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@FelixYBW
Copy link
Contributor

FelixYBW commented Jan 2, 2025

Description

Just noted the velox configurations aren't identical. Some start with spark.gluten.sql.columnar.backend.velox, some are spark.gluten.velox. @zhouyuan @zhztheplayer Do you know the reason?

spark.gluten.sql.columnar.backend.velox.cachePrefetchMinPct
spark.gluten.velox.awsSdkLogLevel

we really need a table to list all spark configurations, velox configurations and what Gluten hornored.

@FelixYBW FelixYBW added the enhancement New feature or request label Jan 2, 2025
@zhouyuan
Copy link
Contributor

zhouyuan commented Jan 3, 2025

Yes, it's not fully cleanedup in legacy code and we are still working on it, here's the configuration improvement plan:
#8326

@FelixYBW
Copy link
Contributor Author

FelixYBW commented Jan 3, 2025

close since it's already tracked

@FelixYBW FelixYBW closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants