-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REST catalog integration tests #1439
Comments
What's going to be the implementation strategy for this integration test? I'd be happy to use my current momentum with REST Catalog to implement the rest of the tests. My current approach would be to migrate the |
I think thats a great first step! Generally, testing via mocked requests is not as resilient as testing against a REST server. Let's move all the mocked tests into the integration rest test. Would you like to work on this? |
Sounds good! Yes, I'll work on it |
(New to PyIceberg, so just spitballing here 😄) @kevinjqliu, have we ever considered taking an approach similar (at a high-level, of course - some details don't transfer over to Python) to the Java-side that has I noticed a bunch of duplication between Glue and Dynamo integration testing here and here respectively that made me wonder why there aren't tests on a PyIceberg |
Yes thats a great idea. The REST TCK (Technology Compatibility Kit) was merged recently apache/iceberg#10908
I think this is a separate but important issue for pyiceberg. I want a set of tests which can be based off the catalog base class. The idea is to make it easier for new catalogs to test the base behaviors. This would be helpful for |
Feature Request / Improvement
#1434 created
tests/integration/test_rest_catalog.py
for integration tests with the REST catalog. Previously REST catalog tests were using mocked requests intests/catalog/test_rest.py
.Let's add more integration tests!
The text was updated successfully, but these errors were encountered: