Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deriving Fields for each invocation of struct and named_struct #14275

Open
pepijnve opened this issue Jan 24, 2025 · 0 comments · May be fixed by #14276
Open

Avoid deriving Fields for each invocation of struct and named_struct #14275

pepijnve opened this issue Jan 24, 2025 · 0 comments · May be fixed by #14276
Labels
enhancement New feature or request

Comments

@pepijnve
Copy link

pepijnve commented Jan 24, 2025

Is your feature request related to a problem or challenge?

struct and named_struct do not yet implement invoke_with_args; only invoke_batch is implemented. Since invoke_batch does not have access to the return type it cannot make use of the Fields instance that's created in that function and instead derives the same value on each invocation.

Describe the solution you'd like

Implement invoke_with_args instead to allow reuse of the already computed Fields and remove the duplicated logic.

Describe alternatives you've considered

None

Additional context

Partial version of #13515 for struct and named_struct.

@pepijnve pepijnve added the enhancement New feature or request label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant