Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for filtered SortMergeJoin output size #14239

Open
comphead opened this issue Jan 22, 2025 · 1 comment
Open

Add tests for filtered SortMergeJoin output size #14239

comphead opened this issue Jan 22, 2025 · 1 comment
Assignees
@comphead

Comments

@comphead
Copy link
Contributor

Are you planning to add some tests to avoid someone breaking this coalescing behavior?

Originally posted by @berkaysynnada in #14160 (review)

Its needed to prevent the regression and cover SMJ and probably other joins with tests showing that query execution with the join outputs the batches close to batch_size
@comphead comphead mentioned this issue Jan 22, 2025
Merged
@comphead
Copy link
Contributor Author

The discussion to make join execution output is #14238

@comphead comphead self-assigned this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comphead comphead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@comphead