Remove uses of #[allow(dead_code)
in favor of names starting with _
#13278
Labels
good first issue
Good for newcomers
TLDR is that we have some code (such as referenced below) that uses
#[allow(dead_code)]
to permit a field that is only present so itsDrop
(destructor) can run.#[allow(dead_code)]
has disadvantage that it can be retained in the code even if the field becomes used_reservation
has disadvantage that it doesn't look prettyOriginally posted by @findepi in #13227 (comment)
@drauschenbach notes: #13227 (comment)
Thus it would be great to update the code to use
_reservation
in the case above, and potentially look in the codebase for other similar uses of#[allow(dead_code)]
and use the_
prefixThe text was updated successfully, but these errors were encountered: