From 17319c2cccc44892ad07d73d19d634be623de4f6 Mon Sep 17 00:00:00 2001 From: Peter Toth Date: Mon, 11 Nov 2024 16:16:51 +0100 Subject: [PATCH] fix comment about min stack requirement --- datafusion/sql/src/query.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datafusion/sql/src/query.rs b/datafusion/sql/src/query.rs index c61ab018c54d..740f9ad3b42c 100644 --- a/datafusion/sql/src/query.rs +++ b/datafusion/sql/src/query.rs @@ -59,8 +59,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { self.select_into(plan, select_into) } other => { - // TODO: check why set_expr_to_plan or the functions it calls need bigger - // minimum stack + // The functions called from `set_expr_to_plan()` need more than 128KB + // stack in debug builds as investigated in: + // https://github.com/apache/datafusion/pull/13310#discussion_r1836813902 let min_stack_size = recursive::get_minimum_stack_size(); recursive::set_minimum_stack_size(256 * 1024); let plan = self.set_expr_to_plan(other, planner_context)?;