GH-45316: [Release][C#] Use GitHub Releases for artifacts

[kou]

Rationale for this change

We don't need to use Artifactory for NuGet packages because it's not published to Artifactory.

What changes are included in this PR?

• Use GitHub Releases for easy to maintain
• Use .github/workflows/csharp.yml instead of nightly job for easy to maintain

Are these changes tested?

Almost yes.

Are there any user-facing changes?

No.

• GitHub Issue: [Release][C#] Use GitHub Releases for artifacts #45316

[github-actions]

⚠️ GitHub issue #45316 has been automatically assigned in GitHub to PR creator.

[raulcd]

Thanks @kou for taking this effort. I've gone through all these changes and everything looks pretty good to me.
I had some minor questions but have been solved once I've gone through the whole changeset, so from my side this can be merged and tried.
The uploaded contents looks good:

Archive:  nuget.zip
  inflating: Apache.Arrow.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.20.0.0-dev-10.snupkg.sha512  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.Compression.20.0.0-dev-10.snupkg.sha512  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.Flight.20.0.0-dev-10.snupkg.sha512  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.Flight.AspNetCore.20.0.0-dev-10.snupkg.sha512  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg.sha256  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.nupkg.sha512  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg.sha256  
  inflating: Apache.Arrow.Flight.Sql.20.0.0-dev-10.snupkg.sha512 

And the release changes to take those into account look also good.
I've also validated that the verify release script does not require changes (it will verify checksums correctly with the current changes).

[kou]

I'm checking tagging cases in my fork...: https://github.com/kou/arrow/releases/tag/apache-arrow-20.0.0-rc0

gh release upload is failing...: https://github.com/kou/arrow/actions/runs/12882744065/job/35921998748#step:11:18

[kou]

I confirmed that the followings work well:

• RC tag: https://github.com/kou/arrow/releases/tag/apache-arrow-20.0.0-rc0
  • GitHub Actions uploads .tar.gz and NuGet packages with .sha256/.sha512
  • dev/release/02-source.sh uploads .asc to GitHub Releases
• Release tag: https://github.com/kou/arrow/releases/tag/apache-arrow-20.0.0
  • GitHub Actions copies artifacts from GitHub Releases RC (.asc isn't copied because I pushed a release tag before dev/release/02-source.sh)
  • dev/release/post-08-csharp.sh downloads from GitHub Releases
  • NuGet packaging job skipped: https://github.com/kou/arrow/actions/runs/12885481674/job/35924035438

[kou]

I'll merge this in a few days if nobody objects this.

[assignUser]

gh release upload is failing...: https://github.com/kou/arrow/actions/runs/12882744065/job/35921998748#step:11:18

The GITHUB_TOKEN needs the contents: write permission to upload releases.

[kou]

gh release upload is failing...: https://github.com/kou/arrow/actions/runs/12882744065/job/35921998748#step:11:18

The GITHUB_TOKEN needs the contents: write permission to upload releases.

Right. I've fixed this by it.

[kou]

I'll merge this.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dc581f0.

There were 14 benchmark results indicating a performance regression:

• Commit Run on test-mac-arm at 2025-01-23 07:05:40Z
  • tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-17, scale_factor=1
  • tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-10, scale_factor=1
• and 12 more (see the report linked below)

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.