Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Remove arrow/result_internal.h #45075

Closed
wgtmac opened this issue Dec 19, 2024 · 1 comment
Closed

[C++] Remove arrow/result_internal.h #45075

wgtmac opened this issue Dec 19, 2024 · 1 comment
Assignees
@wgtmac
Labels
Component: C++ Type: enhancement
Milestone
19.0.0

Comments

@wgtmac
Copy link
Member

wgtmac commented Dec 19, 2024

Describe the enhancement requested

The result_internal.h file contains only the definition of ASSIGN_OR_RAISE and thus can be removed because ARROW_ASSIGN_OR_RAISE is preferred over ASSIGN_OR_RAISE.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Dec 19, 2024
Merged
kou pushed a commit that referenced this issue Dec 19, 2024
@wgtmac
GH-45075: [C++] Remove result_internal.h (#45066)
6f65782 
### Rationale for this change

The result_internal.h file contains only the definition of `ASSIGN_OR_RAISE` and thus can be removed because `ARROW_ASSIGN_OR_RAISE` is preferred over `ASSIGN_OR_RAISE`.

### What changes are included in this PR?

Remove result_internal.h and use `ARROW_ASSIGN_OR_RAISE` to replace `ASSIGN_OR_RAISE`.

### Are these changes tested?

Pass CI.

### Are there any user-facing changes?

No.
* GitHub Issue: #45075

Authored-by: Gang Wu <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member

kou commented Dec 19, 2024

Issue resolved by pull request 45066
#45066

@kou kou added this to the 19.0.0 milestone Dec 19, 2024
@kou kou closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wgtmac wgtmac

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@kou @wgtmac