-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45071: [Packaging][Docs] Fix NumPy v2 include directory for Emscripten, and update Pyodide-related documentation #45072
Conversation
NumPy 2.0 changed the location of the header files
|
@github-actions crossbow submit -g python |
Revision: bb6ff29 Submitted crossbow builds: ursacomputing/crossbow @ actions-a9ba1a0870 |
Thanks for triggering CI! Looks like the failure is unrelated, it's just a timeout. |
Yes, it seems a timeout issue but it's pretty consistent, I just triggered it a 4th time, and it has never failed on our nightly CI. The other CI failures are unrelated. edit: Well, it was successful on the 4th attempt :) |
Glad that it passed :D I would recommend switching to using the Pyodide virtual environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I did more tries and they are stable now. (Why...?)
Could you open new issues for these improvement ideas?
I have no idea either, though FWIW, timeouts and flakes with I'll open a new issue about it, sure! |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7bec4fa. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
This change would allow building PyArrow correctly with NumPy 1.X and NumPy 2.X, since we are trying to do the latter for pyodide/pyodide#4925. This PR closes gh-45071.
What changes are included in this PR?
This PR
Are these changes tested?
Yes, working here: https://github.com/agriyakhetarpal/pyodide-numpy-2.0-rebuilds/actions/runs/12399351376/job/34619554658#step:8:4547 via agriyakhetarpal/pyodide@b651698 that applies a subset of the changes as a patch (the CI job is failing for unrelated reasons, please ignore).
Are there any user-facing changes?
Yes, users trying to build a WASM wheel via Pyodide are now requested to use newer Pyodide and Emscripten versions, and the latest stable version of
pyodide-build
available.pyodide-build
to be the same version as Pyodide #45071