-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45005 [C++] Support for fixed-size list in conversion of range tuple #45008
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @mroz45 . I think this is a good idea, can please address the following comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit of naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now @mroz45 , please just address @zanmato1984 's comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please fix the lint (format) issue in CI. Then I'll merge it. Thanks.
Never mind the format, I've rebased the PR and fixed the format issue. Let's wait for CI. |
The CI failure is unrelated. Merging. Thank you @mroz45 for this! |
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 37eb3b5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
What changes are included in this PR?
This PR introduces support for fixed-size lists in Apache Arrow's STL conversion. Added specializations for arrow::stl::ConversionTraits and arrow::CTypeTraits to handle std::array as a fixed-size list and also Unit Test.
Are these changes tested?
Yes, new type is tested.
Are there any user-facing changes?