Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] No micro-benchmarks for ChunkResolver::ResolveMany() #43953

Closed
felipecrv opened this issue Sep 4, 2024 · 1 comment
Closed

[C++] No micro-benchmarks for ChunkResolver::ResolveMany() #43953

felipecrv opened this issue Sep 4, 2024 · 1 comment
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
18.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

These benchmarks are necessary to validate optimizations.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Sep 4, 2024
Merged
pitrou added a commit that referenced this issue Sep 24, 2024
@felipecrv @pitrou
GH-43953: [C++] Add tests based on random data and benchmarks to Chun…
83f35de 
…kResolver::ResolveMany (#43954)

### Rationale for this change

Improve tests and add benchmarks. I wrote the tests and benchmarks while trying to improve the performance of `ResolveMany` and failing at it.

### What changes are included in this PR?

Tests, benchmarks, and changes that don't really affect performance but might unlock more optimization opportunities in the future.

### Are these changes tested?

Yes.

* GitHub Issue: #43953

Lead-authored-by: Felipe Oliveira Carvalho <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou
Copy link
Member

pitrou commented Sep 24, 2024

Issue resolved by pull request 43954
#43954

@pitrou pitrou added this to the 18.0.0 milestone Sep 24, 2024
@pitrou pitrou closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@felipecrv @pitrou