Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Support for Long memory addresses #43902

Closed
vibhatha opened this issue Sep 2, 2024 · 1 comment
Closed

[Java] Support for Long memory addresses #43902

vibhatha opened this issue Sep 2, 2024 · 1 comment
Assignees
@vibhatha
Labels
Component: Java Type: enhancement
Milestone
18.0.0

Comments

@vibhatha
Copy link
Collaborator

vibhatha commented Sep 2, 2024

Describe the enhancement requested

In the memory-core module, still, there are the usage of Integer instead of Long in case of representing memory addresses, index, and sizes. This must be dealt with and favor long instead of int.

Component(s)

Java
@vibhatha vibhatha self-assigned this Sep 2, 2024
@github-actions github-actions bot mentioned this issue Sep 2, 2024
Merged
lidavidm pushed a commit that referenced this issue Sep 4, 2024
@vibhatha
GH-43902: [Java] Support for Long memory addresses (#43903)
b2e0668 
### Rationale for this change

The usage of `Integer` instead of `Long` must be encouraged with the usage of memory sizing, indexing and addresses. 

### What changes are included in this PR?

This PR refactors the usage of `Integer` into `Long` along with utilities refactors. 

### Are these changes tested?

Existing test cases. 

### Are there any user-facing changes?

Yes, certain API calls may subject changes. 
* GitHub Issue: #43902

Authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Signed-off-by: David Li <[email protected]>
@lidavidm lidavidm added this to the 18.0.0 milestone Sep 4, 2024
@lidavidm
Copy link
Member

lidavidm commented Sep 4, 2024

Issue resolved by pull request 43903
#43903

@lidavidm lidavidm closed this as completed Sep 4, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Sep 6, 2024
@vibhatha @zanmato1984
apacheGH-43902: [Java] Support for Long memory addresses (apache#43903)
86c84df 
### Rationale for this change

The usage of `Integer` instead of `Long` must be encouraged with the usage of memory sizing, indexing and addresses. 

### What changes are included in this PR?

This PR refactors the usage of `Integer` into `Long` along with utilities refactors. 

### Are these changes tested?

Existing test cases. 

### Are there any user-facing changes?

Yes, certain API calls may subject changes. 
* GitHub Issue: apache#43902

Authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Signed-off-by: David Li <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@vibhatha @khwilson
apacheGH-43902: [Java] Support for Long memory addresses (apache#43903)
b50ad30 
### Rationale for this change

The usage of `Integer` instead of `Long` must be encouraged with the usage of memory sizing, indexing and addresses. 

### What changes are included in this PR?

This PR refactors the usage of `Integer` into `Long` along with utilities refactors. 

### Are these changes tested?

Existing test cases. 

### Are there any user-facing changes?

Yes, certain API calls may subject changes. 
* GitHub Issue: apache#43902

Authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhatha vibhatha

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@lidavidm @vibhatha