Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Compute: Adding more comments for RowEncoder #43758

Closed
mapleFU opened this issue Aug 19, 2024 · 1 comment
Closed

[C++] Compute: Adding more comments for RowEncoder #43758

mapleFU opened this issue Aug 19, 2024 · 1 comment
Assignees
@mapleFU
Labels
Component: C++ Type: enhancement
Milestone
18.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Aug 19, 2024

Describe the enhancement requested

Currently RowTable support types haven't been listed, or it's scattered in the code everywhere. I think I'd like to adding more comments before #31180

Component(s)

C++
@mapleFU mapleFU self-assigned this Aug 19, 2024
@github-actions github-actions bot mentioned this issue Aug 19, 2024
Merged
@mapleFU mapleFU changed the title [C++] Compute: Adding more comments for RowTable [C++] Compute: Adding more comments for RowEncoder Aug 21, 2024
@mapleFU mapleFU mentioned this issue Aug 28, 2024
Open
mapleFU added a commit that referenced this issue Sep 2, 2024
@mapleFU @pitrou @zanmato1984
GH-43758: [C++] Compute: More comment in RowEncoder (#43763)
44d3f76 
### Rationale for this change

Some comments for RowEncoder

### What changes are included in this PR?

Some comments for RowEncoder

### Are these changes tested?

Covered by existing

### Are there any user-facing changes?

no

* GitHub Issue: #43758

Lead-authored-by: mwish <[email protected]>
Co-authored-by: mwish <[email protected]>
Co-authored-by: mwish <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Rossi Sun <[email protected]>
Signed-off-by: mwish <[email protected]>
@mapleFU mapleFU added this to the 18.0.0 milestone Sep 2, 2024
@mapleFU
Copy link
Member Author

mapleFU commented Sep 2, 2024

Issue resolved by pull request 43763
#43763

@mapleFU mapleFU closed this as completed Sep 2, 2024
mapleFU added a commit to mapleFU/arrow that referenced this issue Sep 3, 2024
@mapleFU @pitrou @zanmato1984
apacheGH-43758: [C++] Compute: More comment in RowEncoder (apache#43763)
c272fab 
### Rationale for this change

Some comments for RowEncoder

### What changes are included in this PR?

Some comments for RowEncoder

### Are these changes tested?

Covered by existing

### Are there any user-facing changes?

no

* GitHub Issue: apache#43758

Lead-authored-by: mwish <[email protected]>
Co-authored-by: mwish <[email protected]>
Co-authored-by: mwish <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Rossi Sun <[email protected]>
Signed-off-by: mwish <[email protected]>
zanmato1984 added a commit to zanmato1984/arrow that referenced this issue Sep 6, 2024
@mapleFU @pitrou @zanmato1984
apacheGH-43758: [C++] Compute: More comment in RowEncoder (apache#43763)
4490827 
### Rationale for this change

Some comments for RowEncoder

### What changes are included in this PR?

Some comments for RowEncoder

### Are these changes tested?

Covered by existing

### Are there any user-facing changes?

no

* GitHub Issue: apache#43758

Lead-authored-by: mwish <[email protected]>
Co-authored-by: mwish <[email protected]>
Co-authored-by: mwish <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Rossi Sun <[email protected]>
Signed-off-by: mwish <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@mapleFU @pitrou
@zanmato1984 @khwilson
apacheGH-43758: [C++] Compute: More comment in RowEncoder (apache#43763)
a16021a 
### Rationale for this change

Some comments for RowEncoder

### What changes are included in this PR?

Some comments for RowEncoder

### Are these changes tested?

Covered by existing

### Are there any user-facing changes?

no

* GitHub Issue: apache#43758

Lead-authored-by: mwish <[email protected]>
Co-authored-by: mwish <[email protected]>
Co-authored-by: mwish <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Rossi Sun <[email protected]>
Signed-off-by: mwish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@mapleFU