-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41993 [Go] IPC writer shift voffsets when offsets array does not start from zero #43176
Conversation
|
Sorry just noticed a bug, will fix and reopen shortly |
Fix in place, should be good now |
@notfilippo can you give this a try with your example and confirm that this fixes the issue? |
Thanks for the ping. I'll check my internal repro with this new version and let you know asap! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with an internal repro. It works! Thanks @joellubi :)
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1fce293. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
It should be valid to specify offset buffers that do not start from zero. This particularly important for when multiple arrays share a single value buffer.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Variable-length binary arrays that share a value buffer will not result in errors.